Skip to content

Limit repeated warning logs#17889

Open
Caideyipi wants to merge 11 commits into
masterfrom
fix-log-throttling
Open

Limit repeated warning logs#17889
Caideyipi wants to merge 11 commits into
masterfrom
fix-log-throttling

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Summary

  • log login lock messages only when thresholds are first reached
  • suppress duplicate auth attack and ConfigNode connection warnings while the same condition persists
  • throttle repeated disk free-space warnings per directory

Tests

  • mvn -Ddevelocity.off=true -nsu -pl iotdb-core/node-commons spotless:apply
  • mvn -Ddevelocity.off=true -nsu -pl iotdb-core/datanode spotless:apply
  • JUnitCore: org.apache.iotdb.commons.utils.JVMCommonUtilsTest
  • JUnitCore: org.apache.iotdb.db.auth.LoginLockManagerTest org.apache.iotdb.db.auth.AuthorizerManagerTest

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 67.37481% with 215 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.86%. Comparing base (1d893f1) to head (903f2ff).
⚠️ Report is 45 commits behind head on master.

Files with missing lines Patch % Lines
...db/service/metrics/IoTDBInternalLocalReporter.java 28.78% 47 Missing ⚠️
...etrics/metricsets/net/WindowsNetMetricManager.java 0.00% 33 Missing ⚠️
.../metrics/metricsets/net/LinuxNetMetricManager.java 0.00% 24 Missing ⚠️
...e/manager/subscription/SubscriptionMetaSyncer.java 5.55% 17 Missing ⚠️
...torageengine/load/active/ActiveLoadDirScanner.java 39.28% 17 Missing ⚠️
...b/metrics/reporter/iotdb/IoTDBSessionReporter.java 17.64% 14 Missing ⚠️
.../apache/iotdb/db/auth/ClusterAuthorityFetcher.java 43.47% 13 Missing ⚠️
...trics/metricsets/disk/LinuxDiskMetricsManager.java 71.42% 12 Missing ⚠️
...ol/thrift/impl/DataNodeInternalRPCServiceImpl.java 52.94% 8 Missing ⚠️
...ava/org/apache/iotdb/db/auth/LoginLockManager.java 91.22% 5 Missing ⚠️
... and 9 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #17889      +/-   ##
============================================
+ Coverage     41.26%   41.86%   +0.60%     
- Complexity      318      389      +71     
============================================
  Files          5273     5298      +25     
  Lines        368462   372461    +3999     
  Branches      47692    48204     +512     
============================================
+ Hits         152040   155936    +3896     
- Misses       216422   216525     +103     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

# Conflicts:
#	iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/coordinator/runtime/PipeMetaSyncer.java
#	iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/coordinator/runtime/heartbeat/PipeHeartbeatScheduler.java
#	iotdb-core/datanode/src/test/java/org/apache/iotdb/db/conf/directories/strategy/DirectoryStrategyTest.java
#	iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/disk/strategy/MinFolderOccupiedSpaceFirstStrategy.java
@sonarqubecloud

sonarqubecloud Bot commented Jul 3, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant