Fix time partition boundary overflows and splitter partition order#17893
Open
Caideyipi wants to merge 15 commits into
Open
Fix time partition boundary overflows and splitter partition order#17893Caideyipi wants to merge 15 commits into
Caideyipi wants to merge 15 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #17893 +/- ##
============================================
+ Coverage 41.84% 41.99% +0.14%
Complexity 318 318
============================================
Files 5296 5300 +4
Lines 373604 374178 +574
Branches 48232 48323 +91
============================================
+ Hits 156351 157126 +775
+ Misses 217253 217052 -201 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…rtition-boundary-overflow-fix
Caideyipi
changed the title
…rtition-boundary-overflow-fix
…dary-overflow-fix # Conflicts: # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/tsfile/TsFileResource.java
…rtition-boundary-overflow-fix
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This patch fixes overflow-prone time partition boundary handling by making partition boundary calculations origin-aware and saturation-safe. It also preserves TsFile splitter output order for aligned chunks that are split across time partitions, which prevents Long.MAX_VALUE boundary chunks from being emitted in reverse partition order.
The main changes are:
TimePartitionUtilsTests
mvn -pl iotdb-core/node-commons -DskipTests compilemvn -pl iotdb-core/node-commons testcurrently fails duringtestCompilebecauseCommitProgressKeeperTestreferences missingRegionProgress,WriterId, andWriterProgresssymbols, which is unrelated to this change.mvn -pl iotdb-core/datanode spotless:applymvn -pl iotdb-core/datanode -am -Dtest=TsFileSplitterTest#testSplitTableTimeOnlyAlignedChunkAtLongMaxPartitionEnd,testSplitTableTimeOnlyAlignedChunkAtExactLongMaxUpperBound -Dsurefire.failIfNoSpecifiedTests=false -DfailIfNoTests=false testcurrently fails duringdatanodecompile because generatedModeAccumulatorsources reference missingorg.apache.commons.collections4.comparators.ComparatorChainandIoTDBConfig#getModeMapSizeThreshold(), which is unrelated to this splitter change.