Skip to content

[To dev/1.3] Fix partial insert handling for null measurements (#17879)#17922

Open
Caideyipi wants to merge 7 commits into
dev/1.3from
cp-feaeaa6-dev-1.3
Open

[To dev/1.3] Fix partial insert handling for null measurements (#17879)#17922
Caideyipi wants to merge 7 commits into
dev/1.3from
cp-feaeaa6-dev-1.3

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Description

As the title said.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

* Fix partial insert handling for null measurements

* Fix partial insert handling for missing columns

* Fix table insert schema validation for partial insert

* Fix partial insert null column handling

* Fix failed measurement WAL serialization tests

* Fix all-failed tablet test column reuse

(cherry picked from commit feaeaa6)
@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.11111% with 112 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.14%. Comparing base (8e213dd) to head (2950882).
⚠️ Report is 1 commits behind head on dev/1.3.

Files with missing lines Patch % Lines
...ngine/plan/statement/crud/InsertBaseStatement.java 42.22% 26 Missing ⚠️
...ne/plan/planner/plan/node/write/InsertRowNode.java 67.53% 25 Missing ⚠️
...plan/planner/plan/node/write/InsertTabletNode.java 70.00% 24 Missing ⚠️
...engine/plan/statement/crud/InsertRowStatement.java 72.41% 8 Missing ⚠️
...plan/analyze/cache/schema/DataNodeSchemaCache.java 0.00% 7 Missing ⚠️
...ine/plan/statement/crud/InsertTabletStatement.java 83.33% 4 Missing ⚠️
.../main/java/org/apache/iotdb/db/utils/MemUtils.java 85.18% 4 Missing ⚠️
...orm/statement/PipeConvertedInsertRowStatement.java 66.66% 2 Missing ⚠️
...ipe/resource/memory/InsertNodeMemoryEstimator.java 75.00% 2 Missing ⚠️
...ngine/plan/analyze/schema/NormalSchemaFetcher.java 0.00% 2 Missing ⚠️
... and 5 more
Additional details and impacted files
@@              Coverage Diff              @@
##             dev/1.3   #17922      +/-   ##
=============================================
+ Coverage      43.05%   43.14%   +0.08%     
  Complexity       198      198              
=============================================
  Files           3627     3627              
  Lines         242682   242888     +206     
  Branches       29600    29691      +91     
=============================================
+ Hits          104493   104798     +305     
+ Misses        138189   138090      -99     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

# Conflicts:
#	iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/cache/schema/DeviceNormalSchema.java
@sonarqubecloud

sonarqubecloud Bot commented Jul 3, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant