Pipe: improve incremental memory estimation#18049
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #18049 +/- ##
============================================
- Coverage 41.68% 41.62% -0.06%
Complexity 318 318
============================================
Files 5296 5296
Lines 371819 371945 +126
Branches 48106 48137 +31
============================================
- Hits 154975 154815 -160
- Misses 216844 217130 +286 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jt2594838
reviewed
Jun 30, 2026
Comment on lines
+1001
to
+1003
| String.format( | ||
| "%s Need Floating memory: %d bytes, free Floating memory: %d bytes", | ||
| PipeMessages.NOT_ENOUGH_MEMORY_FOR_PIPE, | ||
| PipeConfig.getInstance().getPipeInsertNodeQueueMemory(), | ||
| remainingMemory); | ||
| PipeMessages.NOT_ENOUGH_MEMORY_FOR_PIPE, needFloatingMemory, remainingMemory); |
Collaborator
Author
There was a problem hiding this comment.
Done. I moved the memory check details into PipeMessages with both English and Chinese i18n entries, and updated the code to use those message constants.
…ion-short-term # Conflicts: # iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/agent/task/PipeTaskAgent.java
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR improves the pipe creation memory admission check from a coarse per-pipe estimate to an incremental estimate based on the tasks and sink subtasks that this DataNode will actually create.
Changes include:
Verification
Also ran datanode compile: