Prevent pipe sink task id from logging secrets#18056
Merged
JackieTien97 merged 1 commit intoJun 29, 2026
Merged
Conversation
luoluoyuyu
force-pushed
the
cherry-pick-pipe-sink-task-id-secrets
branch
from
e4ddff8 to
cb6fd77
Compare
* Prevent pipe sink task id from logging secrets * Fix pipe sink subtask compatibility
luoluoyuyu
force-pushed
the
cherry-pick-pipe-sink-task-id-secrets
branch
from
cb6fd77 to
3b29c6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks #17981 / d6d5755 to rc/2.0.10 and resolves the conflict in
PipeSinkSubtaskManagerby preserving the rc branch's internal sorted-key behavior while using the redacted display string for sink task IDs.Validation:
mvn spotless:apply -pl iotdb-core/datanode,iotdb-core/node-commons,iotdb-api/pipe-apigit diff --check iotdb/rc/2.0.10...HEADmvn test -pl iotdb-core/datanode -Dtest=PipeSinkSubtaskTest,PipeSinkSubtaskExecutorTestwas attempted, but the module failed during compile before tests due to pre-existing/generated dependency mismatches such as missingPipePeriodicalLogReducer,PipeSubscribeHeartbeatReq,PipeSinkConstant.getConnectorOrSinkNameWithDefault, and consensus/query interface signature mismatches.