Fix stale deletion resource manager reuse#18057
Merged
Merged
Conversation
jt2594838
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DeletionResourceManager instances are cached by data region id. Closing a manager only closed its buffer and cleared in-memory resources, but left the closed instance in the singleton map. Later tests or callers using the same region id could retrieve the closed manager, fail to persist new deletions, and recover zero deletion resources.
This removes the closed manager from the singleton map and adds a regression test that verifies getInstance returns a fresh manager after close.
Tests