Avoid copying measurements when updating last cache#18059
Merged
jt2594838 merged 2 commits intoJun 30, 2026
Conversation
jt2594838
approved these changes
Jun 30, 2026
jt2594838
pushed a commit
that referenced
this pull request
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Avoid copying measurements on last cache write path
This PR avoids materializing a copied raw measurement array when InsertRow/InsertTablet nodes update last cache. Write nodes pass their existing measurements array to cache update APIs, and cache update resolves raw measurement names from measurement schemas by index.
Preserve alias and failed-column semantics
TableDeviceLastCacheand tree schema cache now resolve schema raw names only when the original measurement slot is still valid, so failed measurements remain skipped.getRawMeasurements()keeps copy-on-write behavior for callers that still need a raw measurement array.Tests
getRawMeasurements()behavior.Validation:
mvn -Ddevelocity.off=true -DspotlessFiles=... -pl iotdb-core/datanode spotless:applygit diff --checkmvn ... test-compilewas attempted but the local workspace fails on existing generated Freemarker sources (IFill,Accumulator,ComparatorChainresolution), unrelated to this change.This PR has:
for an unfamiliar reader.
Key changed/added classes (or packages if there are too many classes) in this PR
InsertNode,InsertRowNode,InsertTabletNode,RelationalInsertRowNode,RelationalInsertTabletNodeTableDeviceLastCache,TableDeviceSchemaCache,TableDeviceCacheEntry,TreeDeviceNormalSchemaTreeDeviceSchemaCacheManagerTest,InsertNodeIsMeasurementFailedTest