Skip to content

Fix stale auth cache denial after grants #18062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Caideyipi wants to merge 1 commit into from
Closed

Fix stale auth cache denial after grants #18062

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion iotdb-core/datanode/src/main/java/org/apache/iotdb/db/auth/ClusterAuthorityFetcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,21 @@ private TSStatus checkPrivilege(
if (remoteCheck) {
return checkPrivilegeFromConfigNode(req).getStatus();
}
return RpcUtils.getStatus(TSStatusCode.NO_PERMISSION);
return confirmCachedDenyFromConfigNode(req);
}
return checkPrivilegeFromConfigNode(req).getStatus();
}

// Cached denials can be stale when login repopulates a user during grant invalidation.
private TSStatus confirmCachedDenyFromConfigNode(TCheckUserPrivilegesReq req) {
TSStatus remoteStatus = checkPrivilegeFromConfigNode(req).getStatus();
if (remoteStatus.getCode() == TSStatusCode.EXECUTE_STATEMENT_ERROR.getStatusCode()
&& CONNECTERROR.equals(remoteStatus.getMessage())) {
return RpcUtils.getStatus(TSStatusCode.NO_PERMISSION);
}
return remoteStatus;
}

@Override
public TSStatus checkUserSysPrivilege(String username, PrivilegeType permission) {
checkCacheAvailable();
Expand Down
Loading