[Pipe] Improve pipe control-flow lock responsiveness#18076
Merged
jt2594838 merged 2 commits intoJul 1, 2026
Conversation
jt2594838
reviewed
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Pipe control operations currently sit behind coarse-grained ConfigNode/DataNode locks. When a transient per-pipe failure happens, the old retry path slept for 3 seconds while still holding the pipe/task-coordinator/node procedure locks, so one problematic pipe could make other pipe operations feel stuck. On the DataNode side,
pushMultiPipeMetaalso stopped at the first per-pipe failure, which made one bad pipe prevent the rest of the batch from being applied.This PR focuses on low-risk acceleration instead of timeout tuning, so users can observe real progress via
show pipesrather than getting a quick timeout with unclear server-side state.Changes
isYieldAfterExecution=true, so the procedure executor releases the global locks and requeues the procedure before retrying.PipeMetaSyncProcedurelast-synced version only after successful completion.PipeProcedureMetricstimer only when the procedure is actually finished, not on retry-yield lock releases.PipeDataNodeAgent.Tests
Added focused UT coverage:
AbstractOperatePipeProcedureV2TestDataNodeInternalRPCServiceImplPushMultiPipeMetaTestVerification
git diff --checkpassed.git diff --cached --checkpassed before commit.Local Maven verification was attempted but blocked by local environment issues unrelated to this patch:
mvn -o test -pl iotdb-core/confignode -Dtest=AbstractOperatePipeProcedureV2Test -DfailIfNoTests=falsefails during main compile because the local cached dependencies do not match current source APIs (PipeMetaKeeper,SystemConstant,TopicConstant, etc.).mvn -o test -pl iotdb-core/datanode -Dtest=DataNodeInternalRPCServiceImplPushMultiPipeMetaTest -DfailIfNoTests=falseand later Spotless/test-compile attempts hit JVM native-memory/pagefile crashes on this Windows environment.