Skip to content

[To dev/1.3] Avoid login lock for pipe auth retry#18101

Open
Caideyipi wants to merge 1 commit into
apache:dev/1.3from
Caideyipi:cp-19a9b15-dev-1.3
Open

[To dev/1.3] Avoid login lock for pipe auth retry#18101
Caideyipi wants to merge 1 commit into
apache:dev/1.3from
Caideyipi:cp-19a9b15-dev-1.3

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Description

Cherry-picks #18048 / 19a9b15 to dev/1.3.

Changes

  • slows pipe retry intervals for authentication failures to avoid receiver login lock
  • preserves the status code in handshake/login failure messages so auth failures can be detected
  • adds PipeSleepIntervalTest coverage for auth-failure detection and sleep behavior

dev/1.3 backport notes

  • dev/1.3 does not have DataNodePipeMessages, so the legacy pipe login message remains a literal string.
  • dev/1.3 does not define TSStatusCode.USER_LOGIN_LOCKED, so the backport uses the 822 code as a compatibility literal.

Tests

  • mvn -Ddevelocity.off=true -pl iotdb-core/node-commons -Dtest=PipeSleepIntervalTest test

This PR has:

  • been self-reviewed.
  • concurrent read
  • concurrent write
  • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the why and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR
  • PipeReportableSubtask
  • PipeAbstractSinkSubtask
  • IoTDBSyncClientManager
  • IoTDBLegacyPipeSink
  • PipeSleepIntervalTest

* Avoid login lock for pipe auth retry

* Fix legacy pipe login message i18n

(cherry picked from commit 19a9b15)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant