[dev/1.3] Pipe: preserve TsFile parse OOM cause#18105
Open
Caideyipi wants to merge 2 commits into
Open
Conversation
(cherry picked from commit f8e393e6f0c0f7c940942eadc2b10171b69d78f6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks f8e393e6f0c0f7c940942eadc2b10171b69d78f6 to dev/1.3.
origin/dev/1.3 already has 8657782, the dev/1.3 counterpart of b871f1e42a8, but it was still wrapping TsFile parse/read failures with PipeException without preserving the cause. That hides PipeRuntimeOutOfMemoryCriticalException from PipeProcessorSubtask's root-cause check and can stop the pipe instead of treating the OOM as a temporary retryable failure.
Changes:
Validation: