Pipe: disable unused logic#18129
Open
Caideyipi wants to merge 2 commits into
Open
Conversation
Caideyipi
force-pushed
the
cp-disable-unused-pipe-logic
branch
from
defacb1 to
45da56a
Compare
Caideyipi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As the title said.
Tests
mvn spotless:apply -pl iotdb-core/node-commons,iotdb-core/confignode,iotdb-core/datanode,integration-test -P with-integration-testsmvn -pl iotdb-core/node-commons -DskipTests compilemvn -pl iotdb-core/confignode -DskipTests compilegit diff --checkgit diff --cached --checkdatanodefull compile was attempted, but this local workspace fails in unrelated generated queryengine/thrift code paths (target/generated-sources/freemarkermissingIFill/Accumulator, and-amreaches thrift generated sources missingjavax.annotation). The modified Pipe files do not appear in those compile errors.