Skip to content

Fix RegionGroupCache activation race #18136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CRZbulabula merged 1 commit into from
Jul 7, 2026
+4 −4
Merged

Fix RegionGroupCache activation race #18136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...src/main/java/org/apache/iotdb/confignode/manager/load/cache/region/RegionGroupCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public RegionGroupCache(String database, Set<Integer> dataNodeIds, boolean isStr
* @param newHeartbeatSample The newest RegionHeartbeatSample
* @param overwrite Able to overwrite Adding or Removing
*/
public void cacheHeartbeatSample(
public synchronized void cacheHeartbeatSample(
int dataNodeId, RegionHeartbeatSample newHeartbeatSample, boolean overwrite) {
// Only cache sample when the corresponding loadCache exists
Optional.ofNullable(regionCacheMap.get(dataNodeId))
Expand All @@ -78,7 +78,7 @@ public void cacheHeartbeatSample(int dataNodeId, RegionHeartbeatSample newHeartb
*
* @param dataNodeId the specified DataNode
*/
public void createRegionCache(int dataNodeId) {
public synchronized void createRegionCache(int dataNodeId) {
regionCacheMap.put(dataNodeId, new RegionCache());
}

Expand All @@ -87,15 +87,15 @@ public void createRegionCache(int dataNodeId) {
*
* @param dataNodeId the specified DataNode
*/
public void removeRegionCache(int dataNodeId) {
public synchronized void removeRegionCache(int dataNodeId) {
regionCacheMap.remove(dataNodeId);
}

/**
* Update currentStatistics based on the latest NodeHeartbeatSamples that cached in the
* slidingWindow.
*/
public void updateCurrentStatistics() {
public synchronized void updateCurrentStatistics() {
regionCacheMap.values().forEach(regionCache -> regionCache.updateCurrentStatistics(false));
Map<Integer, RegionStatistics> regionStatisticsMap =
regionCacheMap.entrySet().stream()
Expand Down
Loading