James 4150 #2919
James 4150 #2919
Conversation
chibenwa
left a comment
chibenwa
left a comment
There was a problem hiding this comment.
Thanks for hanging on.
I suspect a minor rebase issue. Feel free to disregard the comment regarding indent (it's a nitpick).
| return createAttachmentMapper(session); | ||
| } | ||
|
|
||
| public boolean isAttachmentStorageEnabled() { |
There was a problem hiding this comment.
I cannot find where this is actually used
| new PostgresMessageDAO(executorFactory.create(session.getUser().getDomainPart()), blobIdFactory), | ||
| new PostgresMailboxMessageDAO(executorFactory.create(session.getUser().getDomainPart())), | ||
| getModSeqProvider(session), | ||
| getAttachmentMapper(session), | ||
| blobStore, | ||
| blobIdFactory, | ||
| clock); | ||
| new PostgresMessageDAO(executorFactory.create(session.getUser().getDomainPart()), blobIdFactory), | ||
| new PostgresMailboxMessageDAO(executorFactory.create(session.getUser().getDomainPart())), | ||
| getModSeqProvider(session), | ||
| getAttachmentMapper(session), | ||
| blobStore, | ||
| blobIdFactory, | ||
| clock); |
There was a problem hiding this comment.
The diff is full of reindents that makes it harder to read and harder to find what really changed.
There was a problem hiding this comment.
Thanks for the feedback.
I fixed the issue and reverted the unintended re-indentation to keep the diff minimal and focused on the actual change.
| this.mailbox = mailbox; | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
We are missing the critical changes of mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/PostgresMessageManager.java where we actually chose which messageStorer we want: I suspect a rebase issue.
2 participants
JAMES-4150 Make Attachment Storage Optional for PostgreSQL Message Store #2885
This PR includes the changes that were previously implemented in the Postgres branch and have now been merged into the master branch.