Skip to content

style(skills): apply ruff format and wire skills/ into workspace checks - #1077

Open
Arnxvvv wants to merge 1 commit into
apache:mainfrom
Arnxvvv:style/skills-ruff-format
Open

style(skills): apply ruff format and wire skills/ into workspace checks#1077
Arnxvvv wants to merge 1 commit into
apache:mainfrom
Arnxvvv:style/skills-ruff-format

Conversation

@Arnxvvv

@Arnxvvv Arnxvvv commented Aug 10, 2026

Copy link
Copy Markdown

Summary

  • Adopts skills/ as a workspace member (skills/pyproject.toml added and declared in root [tool.uv.workspace] members), bringing helper scripts and guards under standard CI linting, type-checking, and testing.
  • Applies ruff format across all Python code under skills/, reflowing long set literals, regex constants, and multiline argument lists to comply with the 110-character line-length standard without altering runtime logic.
  • Removes temporary skip: deleted the [tool.magpie.checks] skip = ["ruff-format"] block so that run-workspace-check.sh and pre-commit hooks run the formatter check automatically across skills/.

Type of change

  • Skill change (.claude/skills/<name>/) — eval fixtures updated below
  • Tool / bridge contract (tools/<system>/*.md)
  • Python package (tools/*/ with pyproject.toml)
  • Groovy reference impl
  • Cross-cutting (RFC, AGENTS.md, sandbox, privacy-LLM)
  • Documentation (docs/, README.md, CONTRIBUTING.md)
  • Project template (projects/_template/)
  • CI / dev loop (prek, workflows, validators)
  • Other:

Test plan

  • For Python packages touched: uv run pytest / ruff check / mypy passes:
    • uv run --directory skills --project . ruff format --check . (9 files verified formatted)
    • uv run --directory skills --project . ruff check . (all lint rules passed clean)
    • uv run --directory skills --project . python -m mypy . (clean type-check across 9 source files)
    • uv run --directory skills --project . python -m pytest (9 passed in 0.14s)
  • uv lock --check passes with magpie-skills v0.1.0 member resolved.

RFC-AI-0004 compliance

  • HITL — any new mutation is gated on explicit user confirmation
  • Sandbox — no new unrestricted host access; network reach declared in the adapter
  • Vendor neutrality — placeholders (<PROJECT>, <tracker>, <upstream>, <security-list>) used in all skill / tool prose (the check-placeholders prek hook is the mechanical gate)
  • Conversational + correctable — agentic-override path documented if behaviour is adopter-tunable
  • Write-access discipline — no autonomous outbound messages; drafts only, sent on confirmation
  • Privacy LLM — private content does not reach a non-approved LLM; redactor invoked where needed

Linked issues

Notes for reviewers (optional)

  • Includes the foundational infrastructure from PR ci(skills): lint, type-check and test the Python under skills/ #1054 (skills/pyproject.toml, workspace member registration, uv.lock update, and type annotations in scan_ci_runners.py / collect_status.py) along with the mechanical ruff format changes so the branch is completely self-contained and ready for immediate CI testing.

Applies the infrastructure from apache#1054 (create skills/pyproject.toml as a workspace member with ruff, mypy, and pytest config; fix type-checking issues in scan_ci_runners.py and collect_status.py) and then runs ruff format on all Python under skills/.

The formatter reflowed 9 files — long set literals, regex constants, and argument lists wrapped to respect the 110-char line limit. No logic moves.

The temporary [tool.magpie.checks] skip = [ruff-format] block is removed now that formatting has landed. Closes apache#1076.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci(skills): remove the ruff-format skip once the formatting churn lands

1 participant