Skip to content

Issue 289: filter file names one component at a time on 3.x branch#325

Merged
cstamas merged 1 commit intoapache:maven-filtering-3.xfrom
pbarnes-tibco:issue-289-3.x
Mar 2, 2026
Merged

Issue 289: filter file names one component at a time on 3.x branch#325
cstamas merged 1 commit intoapache:maven-filtering-3.xfrom
pbarnes-tibco:issue-289-3.x

Conversation

@pbarnes-tibco
Copy link

@pbarnes-tibco pbarnes-tibco commented Feb 27, 2026

This PR filters file pathnames one component at a time in order to avoid conflicts between the configured escapeString and the file separator. By filtering a component at a time, the file separator does not occur in the path name component being filtered.

This is a fix for issue #289, on the maven-filtering-3.x branch.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

NOTE: Profile run-its does not exist

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

avoid conflicts between the escapeString and the file separator
@cstamas cstamas requested a review from olamy February 27, 2026 22:18
@cstamas cstamas merged commit 270585b into apache:maven-filtering-3.x Mar 2, 2026
11 checks passed
@github-actions
Copy link

github-actions bot commented Mar 2, 2026

@cstamas Please assign appropriate label to PR according to the type of change.

@github-actions github-actions bot added this to the 3.4.1 milestone Mar 2, 2026
@cstamas cstamas added the bug Something isn't working label Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File name filtering does not work when the escapeString is the same as the file separator

2 participants