Skip to content

fix: debounce while(true) in CheckThreadSafetyMojo PMD-Rule: EmptyControlStatement #2370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Pankraz76 wants to merge 1 commit into from
Closed

fix: debounce while(true) in CheckThreadSafetyMojo PMD-Rule: EmptyControlStatement #2370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,10 @@ public void run() {
getLog().info("[MAVEN-CORE-IT-LOG] Thread " + this + " uses " + tccl);
Thread.currentThread().setContextClassLoader(tccl);
while (go.isEmpty()) {
// wait for start
Comment thread
Pankraz76 marked this conversation as resolved.
try {
Thread.sleep(100); // wait for the start
Copy link
Copy Markdown
Contributor Author

@Pankraz76 Pankraz76 Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Thread.sleep(100); // wait for the start
MILLISECONDS.sleep(100); // wait for the start

https://docs.oracle.com/javase/9/docs/api/java/util/concurrent/TimeUnit.html#sleep-long-

} catch (InterruptedException ignored) {
Comment thread
Pankraz76 marked this conversation as resolved.
}
}
for (int j = 0; j < 10 * 1000; j++) {
try {
Expand Down