`try` can use `automatic resource management` 1/2 by Pankraz76 · Pull Request #2401 · apache/maven

Pankraz76 · 2025-05-28T13:49:09Z

after merging this, they will become one:

Pankraz76 · 2025-05-28T16:26:28Z

again NPE:

Error:  Errors: 
Error:    MavenIT0008SimplePluginTest.testit0008:45 » NullPointer Cannot invoke "java.io.File.exists()" because "dir" is null
Error:    MavenIT0010DependencyClosureResolutionTest.testit0010:47 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0011DefaultVersionByDependencyManagementTest.testit0011:44 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0018DependencyManagementTest.testit0018:42 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0021PomProfileTest.testit0021:42 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0030DepPomDepMgmtInheritanceTest.testit0030:40 » NullPointer Cannot invoke "java.io.File.exists()" because "dir" is null
Error:    MavenIT0041ArtifactTypeFromPluginExtensionTest.testit0041:47 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0085TransitiveSystemScopeTest.testit0085:48 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0087PluginRealmWithProjectLevelDepsTest.testit0087:53 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0142DirectDependencyScopesTest.testit0142:56 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0143TransitiveDependencyScopesTest.testitCompileScope:53->run:249 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0143TransitiveDependencyScopesTest.testitProvidedScope:113->run:249 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0143TransitiveDependencyScopesTest.testitRuntimeScope:162->run:249 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0143TransitiveDependencyScopesTest.testitTestScope:211->run:249 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0146InstallerSnapshotNaming.testitNonTimestampedNameWithInstalledSNAPSHOT:102 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0146InstallerSnapshotNaming.testitRemoteDownloadTimestampedName:86 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenITmng0377PluginLookupFromPrefixTest.testitMNG377:49 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenITmng0461TolerateMissingDependencyPomTest.testit:51 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
[INFO] 
Error:  Tests run: 978, Failures: 0, Errors: 18, Skipped: 49
[INFO]

Pankraz76 · 2025-05-29T09:51:43Z

interesting, will give SOC to isolate error.

Pankraz76

dedicate in PR to fix API.

Pankraz76 · 2025-05-29T19:27:46Z

build success assuming new flaky test failing on main as well:

MavenExecutorTestSupport.version:125

Pankraz76 · 2025-05-29T20:11:54Z

lets get this.

Pankraz76 · 2025-05-29T20:22:55Z

items:

Error:  Failures: 
Error:    ForkedMavenExecutorTest>MavenExecutorTestSupport.defaultFsCaptureOutput:168 No INFO found ==> expected: <true> but was: <false>
Error:    ForkedMavenExecutorTest>MavenExecutorTestSupport.defaultFsCaptureOutputWithForcedColor:186 No ANSI codes present ==> expected: <true> but was: <false>
Error:    ForkedMavenExecutorTest>MavenExecutorTestSupport.defaultFsCaptureOutputWithForcedOffColor:206 No INFO found ==> expected: <true> but was: <false>
Error:    ForkedMavenExecutorTest>MavenExecutorTestSupport.version:124 expected: <4.0.0-rc-4-SNAPSHOT> but was: <unknown>
[INFO] 
Error:  Tests run: 54, Failures: 4, Errors: 0, Skipped: 5

Pankraz76 · 2025-05-29T20:24:41Z

Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.version:124 expected: <4.0.0-rc-4-SNAPSHOT> but was:

this one failing on main for me as well.

Pankraz76 · 2025-06-01T18:46:47Z

item:
[INFO] Results:
[INFO]
Error: Failures:
Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.defaultFsCaptureOutput:168 No INFO found ==> expected: but was:
Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.defaultFsCaptureOutputWithForcedColor:186 No ANSI codes present ==> expected: but was:
Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.defaultFsCaptureOutputWithForcedOffColor:206 No INFO found ==> expected: but was:
Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.version:124 expected: <4.0.0-rc-4-SNAPSHOT> but was:
[INFO]
Error: Tests run: 54, Failures: 4, Errors: 0, Skipped: 5
[INFO]

Pankraz76 · 2025-06-02T06:38:21Z

Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.version:124 expected: <4.0.0-rc-4-SNAPSHOT> but was:

this seems flaky. Locally everything´s fine.

Pankraz76 · 2025-06-02T07:08:18Z

lets see if separation is enough to isolate issue.

Pankraz76 · 2025-06-02T11:20:40Z

lets make this 1o1, its persistent issue:

Error: Failures:
Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.defaultFsCaptureOutput:168 No INFO found ==> expected: but was:
Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.defaultFsCaptureOutputWithForcedColor:186 No ANSI codes present ==> expected: but was:
Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.defaultFsCaptureOutputWithForcedOffColor:206 No INFO found ==> expected: but was:
Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.version:124 expected: <4.0.0-rc-4-SNAPSHOT> but was:
[INFO]
Error: Tests run: 5

Pankraz76 · 2025-06-02T19:13:33Z

need to give this dedication

use try-with-resources statement in CatchMojo #2424

Pankraz76 mentioned this pull request May 28, 2025

avoid false IO catch on mkdirs() #2396

Closed

Pankraz76 marked this pull request as ready for review May 28, 2025 13:50

elharo approved these changes May 28, 2025

View reviewed changes

Pankraz76 force-pushed the `try`-can-use-`automatic-resource-management branch from 6cd950e to 24bf3f7 Compare May 29, 2025 10:06

elharo requested changes May 29, 2025

View reviewed changes

Comment thread ...s/maven-it-plugin-log-file/src/main/java/org/apache/maven/plugin/coreit/AbstractLogMojo.java

Pankraz76 force-pushed the `try`-can-use-`automatic-resource-management branch from 24bf3f7 to 64e3eeb Compare May 29, 2025 13:25

Pankraz76 commented May 29, 2025

View reviewed changes

Comment thread compat/maven-embedder/src/main/java/org/apache/maven/cli/props/MavenProperties.java

Pankraz76 commented May 29, 2025

View reviewed changes

Comment thread impl/maven-cli/src/main/java/org/apache/maven/cling/transfer/ConsoleMavenTransferListener.java

Pankraz76 force-pushed the `try`-can-use-`automatic-resource-management branch from 66de8c0 to 188917a Compare May 29, 2025 13:32

Pankraz76 commented May 29, 2025

View reviewed changes

Comment thread compat/maven-embedder/src/main/java/org/apache/maven/cli/props/MavenProperties.java Outdated

Pankraz76 commented May 29, 2025

View reviewed changes

Comment thread ...s/maven-it-plugin-log-file/src/main/java/org/apache/maven/plugin/coreit/AbstractLogMojo.java Outdated

elharo requested changes May 29, 2025

View reviewed changes

Comment thread ...s/maven-it-plugin-log-file/src/main/java/org/apache/maven/plugin/coreit/AbstractLogMojo.java Outdated

Comment thread ...s/maven-it-plugin-log-file/src/main/java/org/apache/maven/plugin/coreit/AbstractLogMojo.java Outdated

Pankraz76 commented May 29, 2025

View reviewed changes

Comment thread impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/LookupInvoker.java

Comment thread impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/LookupInvoker.java

Comment thread impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/LookupInvoker.java

elharo requested changes May 29, 2025

View reviewed changes

Comment thread impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/CommonsCliOptions.java Outdated

elharo requested changes May 29, 2025

View reviewed changes

Comment thread impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/CommonsCliOptions.java Outdated

Pankraz76 force-pushed the `try`-can-use-`automatic-resource-management branch from 6f9277a to 2868991 Compare May 29, 2025 18:54

Pankraz76 commented May 29, 2025

View reviewed changes

Comment thread impl/maven-cli/src/test/java/org/apache/maven/cling/invoker/mvn/MavenInvokerTest.java

Pankraz76 force-pushed the `try`-can-use-`automatic-resource-management branch 2 times, most recently from bc2a256 to 012e5de Compare May 29, 2025 19:23

Pankraz76 commented May 29, 2025

View reviewed changes

Pankraz76 requested a review from elharo May 29, 2025 19:27

Pankraz76 force-pushed the `try`-can-use-`automatic-resource-management branch 2 times, most recently from 5bc68d5 to b6ee7d7 Compare May 29, 2025 19:31

Pankraz76 commented May 29, 2025

View reviewed changes

Pankraz76 force-pushed the `try`-can-use-`automatic-resource-management branch from feabadc to 1e8099b Compare May 29, 2025 19:36

Pankraz76 commented May 29, 2025

View reviewed changes

Comment thread impl/maven-executor/src/test/java/org/apache/maven/cling/executor/MavenExecutorTestSupport.java

elharo requested changes May 29, 2025

View reviewed changes

Comment thread impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/CommonsCliOptions.java Outdated

Pankraz76 force-pushed the `try`-can-use-`automatic-resource-management branch from 1e8099b to a7b5d39 Compare May 29, 2025 20:00

Pankraz76 requested a review from elharo May 29, 2025 20:01

elharo requested changes May 29, 2025

View reviewed changes

Pankraz76 force-pushed the `try`-can-use-`automatic-resource-management branch from a7b5d39 to fae37ed Compare May 29, 2025 20:09

Pankraz76 requested a review from elharo May 29, 2025 20:11

Pankraz76 force-pushed the `try`-can-use-`automatic-resource-management branch from fae37ed to 3d0bb8b Compare May 30, 2025 15:06

Pankraz76 mentioned this pull request May 31, 2025

abstract implicit used API MavenInvoker#customizeSettingsRequest #2406

Closed

9 tasks

elharo approved these changes Jun 1, 2025

View reviewed changes

Pankraz76 changed the title ~~try can use automatic resource management~~ try can use automatic resource management 1/2 Jun 2, 2025

Pankraz76 mentioned this pull request Jun 2, 2025

use try-with-resources statement in CatchMojo #2424

Merged

try can use automatic resource management 1/2

cc3b23b

Pankraz76 force-pushed the `try`-can-use-`automatic-resource-management branch from 3d0bb8b to cc3b23b Compare June 2, 2025 07:07

elharo approved these changes Jun 2, 2025

View reviewed changes

Pankraz76 marked this pull request as draft June 2, 2025 11:38

Pankraz76 closed this Jun 2, 2025

This was referenced Jun 5, 2025

use try-with-resources statement in CommonsCliOptions #2440

Closed

use try-with-resources statement in MavenProperties #2441

Closed

Conversation

Pankraz76 commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Pankraz76 commented May 28, 2025

Uh oh!

Pankraz76 commented May 29, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pankraz76 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pankraz76 commented May 29, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pankraz76 commented May 29, 2025

Uh oh!

Pankraz76 commented May 29, 2025

Uh oh!

Pankraz76 commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Pankraz76 commented Jun 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Pankraz76 commented Jun 2, 2025

Uh oh!

Pankraz76 commented Jun 2, 2025

Uh oh!

Pankraz76 commented Jun 2, 2025

Uh oh!

Pankraz76 commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Pankraz76 commented May 28, 2025 •

edited

Loading

Pankraz76 commented May 29, 2025 •

edited

Loading

Pankraz76 commented Jun 1, 2025 •

edited

Loading

Pankraz76 commented Jun 2, 2025 •

edited

Loading