Update Reformatter to honour case wrap settings with switch expressions (GH7326).#9484
Open
neilcsmith-net wants to merge 2 commits into
Open
Update Reformatter to honour case wrap settings with switch expressions (GH7326).#9484neilcsmith-net wants to merge 2 commits into
neilcsmith-net wants to merge 2 commits into
Conversation
neilcsmith-net
added
the
Java
mbien
approved these changes
Jul 4, 2026
mbien
left a comment
mbien
left a comment
Member
There was a problem hiding this comment.
even though this might be incomplete, its a good change since this makes the NEVER option usable (which is nice for arrow switches since it still wraps blocks correctly, see snippet I posted via comment).
We could consider changing the default to NEVER but this would probably require to update many tests.
Update Reformatter to only add a newline to cases in switch expressions when wrapCaseStatements is set to WRAP_ALWAYS (default). Fixes apache#7326
mbien
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Reformatter to only add a newline to cases in switch expressions when
wrapCaseStatementsis set toWRAP_ALWAYS(default).Fixes #7326
Alternative might be to ignore the force wrap setting when we have an
ARROWrather thanCOLON. I'm not sure the default works as well in those cases.