Open
Conversation
Signed-off-by: William Woodruff <william@astral.sh>
Signed-off-by: William Woodruff <william@astral.sh>
This has two parts: - Workflow-level permissions should always be empty, with jobs having explicit minimal permissions if needed. - actions/checkout should never persist credentials to disk. Signed-off-by: William Woodruff <william@astral.sh>
Actions expressions should always be intermediated through shell-aware variables. Signed-off-by: William Woodruff <william@astral.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there! uv is a downstream user of this crate, and as a result we have an interest in ensuring your CI/CD is as secure, hermetic, and reproducible as possible 🙂
To that end, this PR has a series of commits (each of which can be reviewed separately) that will hopefully improve your default posture. These changes were made based on findings from zizmor.
To summarize:
${FOO}instead of${{ foo }}is a best practice anyways.After all of that, the only remaining default finding is this:
To fix that one, one of the maintainers will need to set up Trusted Publishing and remove your current manual crates.io token. I strongly recommend doing this as a way to reduce your credential exposure risk 🙂
Finally, I've done all this without adding a workflow that will proactively catch new CI/CD issues. However, if you're interested in that, I'd be happy to add one.
Signed-off-by: William Woodruff william@astral.sh