feat: add vector search timing and I/O diagnostics - #711
Merged
Conversation
jerry-024
marked this pull request as draft
August 14, 2026 06:08
jerry-024
changed the title
…timing * upstream/main: fix(vindex): avoid full index reads during refine (apache#708) feat(vindex): build indexes from streamed data splits (apache#707) feat: support deletion vector merge-on-read (apache#706) # Conflicts: # crates/paimon/src/table/vector_search_builder.rs # crates/paimon/src/vindex/mod.rs
* main: perf(vindex): size native batches by active indexes (apache#709) fix(data-evolution): require row tracking and row IDs (apache#718) feat(go): add table write bindings (apache#658) fix(scan): preserve Data Evolution file order in row-id groups (apache#717) fix(file_index): align file index format with Java V1 (apache#719) fix: configure OpenDAL writer chunk size (apache#713) fix(python): release GIL during catalog I/O (apache#716) feat(write): add fixed-bucket write primitives for postpone tables (apache#659) feat: rust examples for creating and querying Paimon tables (apache#648) fix(table): reject row ranges for format tables at read construction (apache#700) perf(arrow): prune IN predicates with row-group stats (apache#705) feat(io): support in-memory local cache (apache#710) fix(dlf): refresh expiring credentials (apache#714) fix(datafusion): normalize index_type in global index procedures (apache#715) fix(auth): fail closed on query-auth tables outside the read boundary (apache#691) # Conflicts: # crates/paimon/src/table/vector_search_builder.rs # crates/paimon/src/vindex/reader.rs
jerry-024
marked this pull request as ready for review
August 17, 2026 03:28
shyjsarah
reviewed
Aug 17, 2026
| ) | ||
| self.timing_enabled, | ||
| )?; | ||
| self.batch_stats = batch_stats; |
Contributor
There was a problem hiding this comment.
Minor: search_batch() stores the collected stats on the reader, but only visit_batch_vector_search() consumes them and emits paimon_vindex_reader. The PK-vector scorer calls load_validated() + search_batch() directly (vector_search_builder.rs:923-935), so with timing enabled that route collects batch/range-I/O diagnostics but returns without publishing them.
Could we make telemetry reporting independent of the convenience wrapper (for example, return/commit the stats from the search API or pass an explicit diagnostics reporter), and add coverage for the PK/hybrid route?
jerry-024
changed the title
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add opt-in timing and I/O diagnostics for locating latency, concurrency waits, and read amplification in vector search. Logs are emitted through the
logcrate only whenPAIMON_LOG_VECTOR_SEARCH_TIMING=1and thepaimon::vector_searchtarget is enabled at debug level.Changes
e6f3b35; unrelated test-only cleanup).Testing
cargo +1.97.0 fmt --all -- --checkcargo +1.97.0 clippy -p paimon --lib -- -D warningscargo +1.97.0 test -p paimon --lib(2302 passed, 1 ignored)git diff --checkNotes
*_sum_msnames and may exceed wall-clock totals.