GH-2607: Improve "null decryptor" exception in column chunk metadata#3341
Closed
ArnavBalyan wants to merge 1 commit into
Closed
GH-2607: Improve "null decryptor" exception in column chunk metadata#3341ArnavBalyan wants to merge 1 commit into
ArnavBalyan wants to merge 1 commit into
Conversation
Member
Author
|
cc @gszadovszky could you please take a look thanks! |
gszadovszky
requested changes
Oct 6, 2025
gszadovszky
left a comment
Contributor
There was a problem hiding this comment.
I think the error message is too detailed related to how the decryption properties can be set. I think there are more options to do this.
I see the point of providing actionable error messages but it is more the job of the application and not the library. Let's keep only the actual message that no decryption properties were provided for the encrypted column.
Member
Author
|
Makes sense, I think the current error string should be sufficient and job owner can debug. Closing this now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Are these changes tested?
Are there any user-facing changes?