Skip to content

GH-2607: Improve "null decryptor" exception in column chunk metadata#3341

Closed
ArnavBalyan wants to merge 1 commit into
apache:masterfrom
ArnavBalyan:arnavb/decryptor-exception
Closed

GH-2607: Improve "null decryptor" exception in column chunk metadata#3341
ArnavBalyan wants to merge 1 commit into
apache:masterfrom
ArnavBalyan:arnavb/decryptor-exception

Conversation

@ArnavBalyan

Copy link
Copy Markdown
Member

Rationale for this change

Are these changes tested?

  • Yes / CI

Are there any user-facing changes?

  • Yes

@ArnavBalyan

Copy link
Copy Markdown
Member Author

cc @gszadovszky could you please take a look thanks!

@gszadovszky gszadovszky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the error message is too detailed related to how the decryption properties can be set. I think there are more options to do this.
I see the point of providing actionable error messages but it is more the job of the application and not the library. Let's keep only the actual message that no decryption properties were provided for the encrypted column.

@ArnavBalyan

Copy link
Copy Markdown
Member Author

Makes sense, I think the current error string should be sufficient and job owner can debug. Closing this now

@ArnavBalyan ArnavBalyan closed this Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make "null decryptor" exception more informative

2 participants