Skip to content

Catalog Migrator: Add missing BUNDLE-NOTICE and BUNDLE-LICENSE entries #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ajantha-bhat wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Catalog Migrator: Add missing BUNDLE-NOTICE and BUNDLE-LICENSE entries #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions iceberg-catalog-migrator/cli/BUNDLE-LICENSE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1239,6 +1239,13 @@ License: BSD 3-Clause

--------------------------------------------------------------------------------

This artifact bundles iq80 LevelDB (Java port of LevelDB).

Project URL: https://github.com/dain/leveldb
License: Apache License, Version 2.0 - http://www.apache.org/licenses/LICENSE-2.0.txt

--------------------------------------------------------------------------------

This artifact bundles Project Nessie.

Project URL: https://github.com/projectnessie/nessie
Expand Down
57 changes: 57 additions & 0 deletions iceberg-catalog-migrator/cli/BUNDLE-NOTICE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,3 +165,60 @@ This artifact bundles Netty with the following in its NOTICE:
| * HOMEPAGE:
| * https://github.com/JCTools/JCTools

-------------------------------------------------------------------------

This artifact bundles Snappy Java with the following in its NOTICE:
| This product includes software developed by Google Snappy.
| (http://code.google.com/p/snappy)
|
| This product includes software developed by Apache
| PureJavaCrc32C from apache-hadoop-common.
| (http://hadoop.apache.org)

Comment on lines +170 to +177

@dimas-b dimas-b Mar 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cf. https://github.com/xerial/snappy-java/blob/main/NOTICE

(which version do we bundle?)

Why do we not mention the "google" and "PureJavaCrc32C" fragments exactly as in the upstream NOTICE?

Why do not mention "libstdc++"?

Why do not mention Hadoop? The LICENSE file mentions that it is bundled 🤔

Should we also include the "Contributors" section from upstream? I tend to think we should since it's part of Snappy-java's original NOTICE

-------------------------------------------------------------------------

This artifact bundles HawtJNI with the following in its NOTICE:
| This product includes software developed by FuseSource Corp.
| http://fusesource.com
|
| This product includes software developed at
| Progress Software Corporation and/or its subsidiaries or affiliates.
|
| This product includes software developed by IBM Corporation and others.

-------------------------------------------------------------------------

This artifact bundles BoneCP with the following in its NOTICE:
| BoneCP
| Copyright 2010 Wallace Wadge

-------------------------------------------------------------------------

This artifact bundles Eigenbase Properties with the following in its NOTICE:
| eigenbase-properties
| Copyright (C) 2012-2020, Julian Hyde
| This product includes software from the Eigenbase project, licensed from
| DynamoBI Corporation.
| Copyright (C) 2005 Dynamo BI Corporation

-------------------------------------------------------------------------

This artifact bundles Groovy with the following in its NOTICE:
| Apache Groovy
| Copyright 2003-2015 The Apache Software Foundation
|
| This product includes software developed at
| The Apache Software Foundation (http://www.apache.org/).
|
| It includes the following other software:
|
| Antlr 2 (http://www.antlr2.org/)
| ASM (http://asm.ow2.org/)
| GPars (http://www.gpars.org/)
| Hamcrest (https://github.com/hamcrest/JavaHamcrest)
| JCommander (http://jcommander.org/)
| Openbeans (https://code.google.com/p/openbeans/)
| QDox (http://qdox.codehaus.org/)
| TestNG (http://testng.org/)
| XStream (http://xstream.codehaus.org/)