Skip to content

[feat] Support table view.#147

Closed
shibd wants to merge 3 commits into
apache:mainfrom
shibd:table_view
Closed

[feat] Support table view.#147
shibd wants to merge 3 commits into
apache:mainfrom
shibd:table_view

Conversation

@shibd
Copy link
Copy Markdown
Member

@shibd shibd commented Dec 15, 2022

Master Issue: #89

Motivation

#89

Modifications

  1. Reader support readeNextAsync interface.
  2. Support for TableView for the non-partition topic.

NOTE: Since Reader does not support the partitioned topic, I will open a new PR to support it and test TableView under the partition topic.

Verifying this change

This change added tests and can be verified as follows:

  1. Add the ReaderTest.testAsyncRead unit test to cover [Modifications][1]
  2. Add the TableViewTest unit test to cover [Modifications][2]

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@shibd shibd changed the title Support table view. [feat] Support table view. Dec 16, 2022
Comment thread tests/TableViewTest.cc
@shibd
Copy link
Copy Markdown
Member Author

shibd commented Jan 18, 2023

Blocked by #176 and #154

@shibd shibd marked this pull request as draft January 18, 2023 02:28
@shibd shibd self-assigned this Jan 19, 2023
@shibd shibd added the enhancement New feature or request label Jan 19, 2023
@shibd shibd added this to the 3.2.0 milestone Jan 19, 2023
@shibd shibd closed this Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants