[improve] Refactor client version format#206
Merged
Merged
Conversation
## Motivation Currently, the client_version only shows the version information. And clients in different languages use their own separate version numbers. This can lead to conflict. For example, the java client 2.10.2 uses the same value 2.10.2 as the C++ client 2.10.2. And C++ client 3.0.0 may conflict with the future java client 3.0.0. The information of client_version is incomplete. We could not determine what language(or specific library) the client uses. This raises inconvenience for debugging. Please see the discussion: https://lists.apache.org/thread/n59k537fhthjnzkfxtc2p4zk4l0cv3mp ## Modification * Change the client version value to Pulsar-C++-vXXX
shibd
approved these changes
Feb 28, 2023
shibd
reviewed
Feb 28, 2023
Member
|
For Node.js and Python clients, How do we set this parameter? |
Member
Author
I made a discussion here: https://lists.apache.org/thread/ldmtjrqvz6bz2flpdl89k9ogybcm9mj1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the
client_versiononly shows the version information. And clients in different languages use their own separate version numbers. This can lead to conflict. For example, the java client 2.10.2 uses the same value2.10.2as the C++ client 2.10.2. And C++ client 3.0.0 may conflict with the future java client 3.0.0. The information ofclient_versionis incomplete. We could not determine what language(or specific library) the client uses. This raises inconvenience for debugging.This PR adopts a new client version format for the C++ client.
Please see the discussion: https://lists.apache.org/thread/n59k537fhthjnzkfxtc2p4zk4l0cv3mp
Modifications
Pulsar-C++-vXXXVerifying this change
This change added tests.
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)