[docs] Fix the developer guide for macOS users#279
Merged
Conversation
### Motivation We don't need to install `boost-python3`, which was required for the Python wrapper that is independent now. And the latest `googletest` dependency requires the C++14 support so that we need to pass an extra CMake option for it. See apache#269
BewareMyPower
requested review from
Demogorgon314,
RobertIndie,
hezhangjian,
shibd and
tisonkun
tisonkun
approved these changes
Jun 4, 2023
Demogorgon314
approved these changes
Jun 5, 2023
hezhangjian
approved these changes
Jun 5, 2023
Contributor
Author
|
Just found a very flaky (or broken?) test, I will fix it ASAP: #280 |
RobertIndie
approved these changes
Jun 5, 2023
Member
|
Merging... Thanks for your updates! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We don't need to install
boost-python3, which was required for the Python wrapper that is independent now. And the latestgoogletestdependency requires the C++14 support so that we need to pass an extra CMake option for it. See #269Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)