Skip to content

[fix] producer do not create when topic update partition #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BewareMyPower merged 2 commits into from
Jul 1, 2023
Merged

[fix] producer do not create when topic update partition #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b0e3aa
fix can not update producer partition
Jun 29, 2023
2a185ee
improve the PartitionsUpdateTest
Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/PartitionedProducerImpl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,8 +471,8 @@ void PartitionedProducerImpl::handleGetPartitions(Result result,
}
} else {
LOG_WARN("Failed to getPartitionMetadata: " << strResult(result));
runPartitionUpdateTask();
}
runPartitionUpdateTask();
}

bool PartitionedProducerImpl::isConnected() const {
Expand Down
9 changes: 9 additions & 0 deletions tests/PartitionsUpdateTest.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,11 @@ static void waitForPartitionsUpdated() {
std::this_thread::sleep_for(std::chrono::seconds(3));
}

static void waitForPartitionUpdateTaskRunMultipleTimes() {
// Assume runPartitionUpdateTask run more than one time in 2 seconds if enabled
std::this_thread::sleep_for(std::chrono::seconds(2));
}

TEST(PartitionsUpdateTest, testConfigPartitionsUpdateInterval) {
ClientConfiguration clientConfig;
ASSERT_EQ(60, clientConfig.getPartitionsUpdateInterval());
Expand Down Expand Up @@ -131,6 +136,7 @@ void testPartitionsUpdate(bool lazyStartPartitionedProducers, std::string topicN
ASSERT_EQ(ResultOk, partitionsSet.initProducer(topicName, true, lazyStartPartitionedProducers));
ASSERT_EQ(ResultOk, partitionsSet.initConsumer(topicName, true));

waitForPartitionUpdateTaskRunMultipleTimes();
res = makePostRequest(topicOperateUrl, "3"); // update partitions to 3
ASSERT_TRUE(res == 204 || res == 409) << "res: " << res;
waitForPartitionsUpdated();
Expand All @@ -143,6 +149,7 @@ void testPartitionsUpdate(bool lazyStartPartitionedProducers, std::string topicN
ASSERT_EQ(ResultOk, partitionsSet.initProducer(topicName, true, false));
ASSERT_EQ(ResultOk, partitionsSet.initConsumer(topicName, false));

waitForPartitionUpdateTaskRunMultipleTimes();
res = makePostRequest(topicOperateUrl, "5"); // update partitions to 5
ASSERT_TRUE(res == 204 || res == 409) << "res: " << res;
waitForPartitionsUpdated();
Expand All @@ -155,6 +162,7 @@ void testPartitionsUpdate(bool lazyStartPartitionedProducers, std::string topicN
ASSERT_EQ(ResultOk, partitionsSet.initProducer(topicName, false, false));
ASSERT_EQ(ResultOk, partitionsSet.initConsumer(topicName, true));

waitForPartitionUpdateTaskRunMultipleTimes();
res = makePostRequest(topicOperateUrl, "7"); // update partitions to 7
ASSERT_TRUE(res == 204 || res == 409) << "res: " << res;
waitForPartitionsUpdated();
Expand All @@ -167,6 +175,7 @@ void testPartitionsUpdate(bool lazyStartPartitionedProducers, std::string topicN
ASSERT_EQ(ResultOk, partitionsSet.initProducer(topicName, false, false));
ASSERT_EQ(ResultOk, partitionsSet.initConsumer(topicName, false));

waitForPartitionUpdateTaskRunMultipleTimes();
res = makePostRequest(topicOperateUrl, "10"); // update partitions to 10
ASSERT_TRUE(res == 204 || res == 409) << "res: " << res;
waitForPartitionsUpdated();
Expand Down