Avoid blocking the message listener threads#332
Merged
Conversation
bd72300 to
40c4a24
Compare
BewareMyPower
approved these changes
Oct 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The message listener thread blocks when the receiver queue of
MultiTopicsConsumerImplis full. As message listener threads are used by all consumers in the sameClient, if one slow consumer blocks the listener threads, all other consuemrs can no longer receive new messages.Modifications
MultiTopicsConsumerImplto useUnboundedBlockingQueueto avoid blockingMultiTopicsConsumerImplVerifying this change
This change added tests and can be verified as follows:
testNoListenerThreadBlockingDocumentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-neededIt's just an optimization.
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)