Fix macOS cross-architecture build on arm64 when target arch is x86_64#582
Merged
Merged
Conversation
Contributor
Author
|
Let's see if the workflow here would succeed: https://github.com/BewareMyPower/pulsar-client-cpp/actions/runs/26575230054 |
Contributor
Author
The candidate release is fine.
|
shibd
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix failure like https://github.com/apache/pulsar-client-cpp/actions/runs/26558894568/job/78281724880
The runner is
macos-14, which isarm64, but the workflow sets:The old CMake logic checked only
CMAKE_SYSTEM_PROCESSOR == x86_64. On that runner, CMAKE_SYSTEM_PROCESSOR still reports the host architecture, arm64, so CMake skipped the x86 compile flags:-msse4.2 -mpclmul.