Skip to content

[feat] Support expiration for chunked messages#71

Merged
RobertIndie merged 12 commits into
apache:mainfrom
RobertIndie:improve-chunk
Nov 7, 2022
Merged

[feat] Support expiration for chunked messages#71
RobertIndie merged 12 commits into
apache:mainfrom
RobertIndie:improve-chunk

Conversation

@RobertIndie
Copy link
Copy Markdown
Member

Motivation

Add support for checking expiration for incomplete chunked messages.

Modifications

  • Add configuration expireTimeOfIncompleteChunkedMessageMs to the consumer.
  • Add timer to check the expiration incomplete chunked messages

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@RobertIndie RobertIndie self-assigned this Oct 25, 2022
@RobertIndie RobertIndie marked this pull request as ready for review October 25, 2022 11:20
@RobertIndie RobertIndie added this to the 3.1.0 milestone Oct 26, 2022
Copy link
Copy Markdown
Member

@shibd shibd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some small comments.

Comment thread lib/ConsumerImpl.h Outdated
Comment thread lib/ConsumerImpl.cc Outdated
Comment thread lib/ConsumerImpl.cc Outdated
Comment thread lib/ConsumerImpl.cc Outdated
@RobertIndie RobertIndie requested a review from shibd October 28, 2022 02:49
Comment thread lib/ConsumerImpl.cc Outdated
Comment thread lib/ConsumerImpl.cc
@RobertIndie RobertIndie requested a review from shibd October 28, 2022 05:09
Copy link
Copy Markdown
Member

@shibd shibd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase main branch.

Comment thread lib/ConsumerImpl.cc Outdated
Comment thread lib/ConsumerImpl.cc Outdated
Comment thread lib/ConsumerImpl.cc
Comment thread lib/ConsumerImpl.cc
Comment thread lib/ConsumerImpl.cc Outdated
Comment thread lib/ConsumerImpl.h Outdated
Comment thread lib/ConsumerImpl.h Outdated
RobertIndie and others added 2 commits November 7, 2022 10:57
Co-authored-by: Yunze Xu <xyzinfernity@163.com>
@RobertIndie RobertIndie merged commit 74ef1a0 into apache:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants