fix(security): 2 improvements across 2 files#1492
Open
tomaioo wants to merge 2 commits into
Open
Conversation
- Security: Integer Overflow in Negative Ack Backoff Policy - Security: Potential SSRF via Issuer URL in OIDC Endpoint Provider Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Security: Integer Overflow in Negative Ack Backoff Policy - Security: Potential SSRF via Issuer URL in OIDC Endpoint Provider Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
RobertIndie
reviewed
May 26, 2026
Member
RobertIndie
left a comment
RobertIndie
left a comment
There was a problem hiding this comment.
Could you add a test to verify the change? And please refine the PR to reflect the change. It's better to split two issue fixes into 2 PRs.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to strengthen security in two areas of the Go Pulsar client: (1) making default negative-ack backoff safer under extreme redelivery counts, and (2) tightening validation of OIDC issuer URLs before fetching the .well-known configuration.
Changes:
- Add a guard in the default nack backoff policy intended to prevent overflow in exponential backoff calculation.
- Add issuer URL validation (HTTPS scheme + non-empty host) before fetching OIDC well-known endpoints.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
pulsar/negative_backoff_policy.go |
Adds a redelivery-count guard before performing a left-shift backoff calculation. |
oauth2/oidc_endpoint_provider.go |
Adds issuer URL validation (scheme/host) before performing the HTTP GET to the well-known endpoint. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+44
to
49
| if redeliveryCount >= 63 { | ||
| return maxNackTime | ||
| } | ||
|
|
||
| backoff := float64(minNackTime << redeliveryCount) | ||
| return time.Duration(math.Min(backoff, float64(maxNackTime))) |
Comment on lines
+44
to
+46
| // Validate URL scheme - only allow HTTPS to prevent SSRF attacks | ||
| if u.Scheme != "https" { | ||
| return nil, errors.New("issuer URL must use HTTPS scheme") |
Comment on lines
+44
to
+50
| // Validate URL scheme - only allow HTTPS to prevent SSRF attacks | ||
| if u.Scheme != "https" { | ||
| return nil, errors.New("issuer URL must use HTTPS scheme") | ||
| } | ||
|
|
||
| // Validate host is not empty | ||
| if u.Host == "" { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 2 files
Problem
Severity:
High| File:pulsar/negative_backoff_policy.go:L30In pulsar/negative_backoff_policy.go, the backoff calculation uses bit shift (minNackTime << redeliveryCount) which can overflow when redeliveryCount is large. The overflow causes backoff to become 0, resulting in immediate retry without any delay, potentially causing a denial of service.
Solution
Add overflow check before the shift operation: if redeliveryCount >= 63 { return maxNackTime }. Also consider using math.Min with a pre-computed maximum to avoid the overflow entirely.
Changes
pulsar/negative_backoff_policy.go(modified)oauth2/oidc_endpoint_provider.go(modified)