[feat][cpp] Consumer support batch receive messages.#17429
Closed
shibd wants to merge 6 commits into
Closed
Conversation
Member
Author
|
/pulsarbot run-failure-checks |
shibd
force-pushed
the
batch_receive
branch
2 times, most recently
from
29d203d to
2cfe667
Compare
BewareMyPower
requested review from
BewareMyPower,
Demogorgon314,
RobertIndie,
massakam,
merlimat and
rdhabalia
BewareMyPower
requested changes
Sep 21, 2022
github-actions
Bot
added
the
doc
Contributor
|
@Anonymitaet @momo-jun Could any of you help review the document parts (i.e. files under |
BewareMyPower
requested changes
Sep 21, 2022
BewareMyPower
requested changes
Sep 21, 2022
shibd
force-pushed
the
batch_receive
branch
from
2cfe667 to
853dfbe
Compare
momo-jun
reviewed
Sep 22, 2022
momo-jun
reviewed
Sep 22, 2022
momo-jun
reviewed
Sep 22, 2022
Anonymitaet
reviewed
Sep 22, 2022
shibd
force-pushed
the
batch_receive
branch
from
41b5b37 to
02a66d5
Compare
1 task
Member
Author
|
Resubmit the PR in pulsar-client-cpp repository: apache/pulsar-client-cpp#21 |
BewareMyPower
pushed a commit
to apache/pulsar-client-cpp
that referenced
this pull request
Oct 18, 2022
### Motivation apache/pulsar#17140 This PR has been reviewed in [pulsar repo](apache/pulsar#17429). ### Modifications - Consumer support batch receives messages. - Abstract common implementation to `ConsumerImplBase`.
merlimat
pushed a commit
to merlimat/pulsar-client-cpp
that referenced
this pull request
Oct 20, 2022
### Motivation apache/pulsar#17140 This PR has been reviewed in [pulsar repo](apache/pulsar#17429). ### Modifications - Consumer support batch receives messages. - Abstract common implementation to `ConsumerImplBase`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#17140
Modifications
ConsumerImplBase.acknowledge(Messages<?> messages)is not supported for the time being, and it needs to implement [feature request] C++ client support acknowledging a list of messages pulsar-client-cpp#90 first.Documentation
docMatching PR in forked repository
shibd#15