Skip to content

[feat] PIP-468: sealed-segment retention GC for scalable topics #25668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merlimat merged 2 commits into from
May 5, 2026
+496 −2
Merged

[feat] PIP-468: sealed-segment retention GC for scalable topics #25668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c9a04c
[feat][broker] PIP-468: sealed-segment retention GC for scalable topics
merlimat May 5, 2026
3b1dc1a
[improve][broker] PIP-468: address review on segment GC
merlimat May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3536,6 +3536,13 @@ public boolean isReplicationBacklogExist() {

@Override
public void checkGC() {
if (TopicName.get(topic).isSegment()) {
// Segment-backing topics are owned by ScalableTopicController; its GC tick
// decides when a sealed segment is drained + retention-expired and deletes
// the topic. Letting v4 inactive-topic-GC race against that would risk the
// broker quietly tearing down a segment the controller still considers live.
return;
}
if (!isDeleteWhileInactive()) {
// This topic is not included in GC
return;
Expand Down
Loading
Loading