Skip to content

[improve][test] Set diskUsageThreshold to 0.999 for tests to effectively disable the check#25677

Merged
merlimat merged 1 commit intoapache:masterfrom
lhotari:lh-relax-bk-disk-usage-threshold-for-tests
May 5, 2026
Merged

[improve][test] Set diskUsageThreshold to 0.999 for tests to effectively disable the check#25677
merlimat merged 1 commit intoapache:masterfrom
lhotari:lh-relax-bk-disk-usage-threshold-for-tests

Conversation

@lhotari
Copy link
Copy Markdown
Member

@lhotari lhotari commented May 5, 2026

Motivation

The shared test BookKeeper clusters used by SharedPulsarCluster and SharedMultiBrokerPulsarCluster rely on BookKeeper's default diskUsageThreshold (0.95). When a developer's local disk is more than 95% full, all bookies are flagged as read-only on startup, and tests that need writable bookies fail with the obscure error Not enough non-faulty bookies available. The disk-usage check is irrelevant to the behavior these tests are exercising, so the threshold should be effectively disabled to keep the tests environment-agnostic.

Modifications

  • In SharedPulsarCluster and SharedMultiBrokerPulsarCluster, set diskUsageThreshold to 0.999 and diskUsageWarnThreshold to 0.99 on the BookKeeper server configuration so the check no longer fails tests on machines with nearly-full disks.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

@lhotari lhotari added this to the 5.0.0-M1 milestone May 5, 2026
@merlimat merlimat merged commit cc78878 into apache:master May 5, 2026
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants