[improve][test] Set diskUsageThreshold to 0.999 for tests to effectively disable the check#25677
Merged
merlimat merged 1 commit intoapache:masterfrom May 5, 2026
Conversation
…ely disable the check
PavelZeger
approved these changes
May 5, 2026
merlimat
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The shared test BookKeeper clusters used by
SharedPulsarClusterandSharedMultiBrokerPulsarClusterrely on BookKeeper's defaultdiskUsageThreshold(0.95). When a developer's local disk is more than 95% full, all bookies are flagged as read-only on startup, and tests that need writable bookies fail with the obscure errorNot enough non-faulty bookies available. The disk-usage check is irrelevant to the behavior these tests are exercising, so the threshold should be effectively disabled to keep the tests environment-agnostic.Modifications
SharedPulsarClusterandSharedMultiBrokerPulsarCluster, setdiskUsageThresholdto0.999anddiskUsageWarnThresholdto0.99on the BookKeeper server configuration so the check no longer fails tests on machines with nearly-full disks.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts: