[fix][meta] Fix NPE in shouldIgnoreEvent when MetadataEvent options is null#26200
Merged
Merged
Conversation
nodece
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
AbstractMetadataStore#shouldIgnoreEventnormalizes a possibly-nullMetadataEvent#getOptions()into a localoptionsvariable(
options = event.getOptions() != null ? event.getOptions() : Collections.emptySet()),but the ephemeral/sequential check on the next lines only used it for the first half of
the condition:
When a synchronizer delivers a MetadataEvent whose options is null and the metadata
is not Ephemeral, the short-circuit falls through to
event.getOptions().contains(...) and throws a NullPointerException, so the event
fails to be processed instead of being handled by the remaining checks.
Modifications
Use the null-normalized local options variable for the CreateOption.Sequential
check as well, matching the CreateOption.Ephemeral check on the same line. No
behavior change other than removing the NPE path.