QPID-7148: Use more modern CMake install machinery for better QpidConfig.cmake#33
Open
jiridanek wants to merge 1 commit intoapache:mainfrom
Open
QPID-7148: Use more modern CMake install machinery for better QpidConfig.cmake#33jiridanek wants to merge 1 commit intoapache:mainfrom
jiridanek wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
Author
|
TODO
|
Contributor
Author
|
It appears that this really fixes the build for me rh-messaging/cli-cpp#71 The issue is that Bazel moves the installed library around, and requires |
Contributor
Author
|
As far as I can remember, federation tests are broken and failure can be ignored https://app.travis-ci.com/github/apache/qpid-cpp/builds/256978344#L2108 |
…ig.cmake Turns out, CMake is happy to generate a lot of the QpidConfig.cmake file for us, see * https://gitlab.kitware.com/cmake/cmake/-/issues/19560 * https://cmake.org/cmake/help/latest/manual/cmake-packages.7.html#creating-packages * https://cmake.org/cmake/help/latest/guide/importing-exporting/index.html#exporting-targets * https://cmake.org/cmake/help/latest/module/CMakePackageConfigHelpers.html#example-generating-package-files * https://cmake.org/cmake/help/latest/guide/tutorial/Packaging%20Debug%20and%20Release.html This is analogous change to PROTON-2254 for Qpid Proton.
f8ed352 to
e781482
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out, CMake is happy to generate a lot of the QpidConfig.cmake file for us, see
This is analogous change to PROTON-2254 for Qpid Proton.