Skip to content

PROTON-2938: WIN: Fix Heap Corruption Issue #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamwhy wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −4
Open

PROTON-2938: WIN: Fix Heap Corruption Issue #448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions c/src/proactor/win_iocp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -932,7 +932,8 @@ ssize_t pni_iocp_begin_write(iocpdesc_t *iocpd, const void *buf, size_t len, boo
}
if (iocpd->write_closed) {
assert(pn_error_code(iocpd->error));
pn_error_copy(error, iocpd->error);
if (error != iocpd->error)
pn_error_copy(error, iocpd->error);
if (iocpd->iocp->iocp_trace)
iocp_log("write error: %s\n", pn_error_text(error));
return SOCKET_ERROR;
Expand Down Expand Up @@ -1122,10 +1123,12 @@ ssize_t pni_iocp_recv(iocpdesc_t *iocpd, void *buf, size_t size, bool *would_blo
return SOCKET_ERROR;
}
if (iocpd->read_closed) {
if (pn_error_code(iocpd->error))
pn_error_copy(error, iocpd->error);
else
if (pn_error_code(iocpd->error)) {
if (error != iocpd->error)
pn_error_copy(error, iocpd->error);
} else {
set_iocp_error_status(error, PN_ERR, WSAENOTCONN);
}
return SOCKET_ERROR;
}

Expand Down
Loading