[bug] fix RepicatorCheckpointTask add acl ak/sk - #551
Open
LittleBoy18 wants to merge 1 commit into
Open
Conversation
RockteMQ-AI
approved these changes
Jun 11, 2026
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Review: Approved ✅
PR: #551 — Fix ReplicatorCheckpointTask add ACL ak/sk
Type: Bug fix (1 file, +4/-0)
Assessment
Adds missing ACL access key/secret key configuration to the replicator checkpoint task. Minimal 4-line fix.
Verdict
✅ Correct fix for missing ACL credentials in replicator checkpoint flow.
🤖 Automated review by oss-sentinel-ai
RockteMQ-AI
approved these changes
Aug 17, 2026
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
Bug fix for ACL credential propagation in ReplicatorCheckpointTask. The PR adds the missing access key and secret key configuration for both source and destination endpoints, which are required when ACL is enabled on RocketMQ clusters.
Findings
- [Info] The fix is minimal and targeted — it only adds the four missing credential fields without changing other logic.
- [Info] Consider adding a unit test that verifies the credentials are properly propagated when ACL is enabled, to prevent regression.
Suggestions
The fix is correct and necessary for ACL-enabled deployments.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
fix [ISSUE #550]
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.