Skip to content

[ISSUE #10490] Eliminate per-RPC allocation from Logback status, TopicMessageType toLowerCase, and RemotingHelper eager evaluation #10491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wang-jiahua wants to merge 1 commit into
base: develop
Choose a base branch
from
+9 −3
Open

[ISSUE #10490] Eliminate per-RPC allocation from Logback status, TopicMessageType toLowerCase, and RemotingHelper eager evaluation #10491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions broker/src/main/resources/rmq.broker.logback.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@

<configuration scan="true" scanPeriod="30 seconds">

<statusListener class="ch.qos.logback.core.status.NopStatusListener"/>
Comment thread
wang-jiahua marked this conversation as resolved.

<appender name="DefaultSiftingAppender_inner" class="ch.qos.logback.classic.sift.SiftingAppender">
<discriminator>
<key>brokerContainerLogDir</key>
Expand Down
4 changes: 3 additions & 1 deletion common/src/main/java/org/apache/rocketmq/common/attribute/TopicMessageType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,11 @@ public enum TopicMessageType {
MIXED("MIXED");

private final String value;
private final String metricsValue;

TopicMessageType(String value) {
this.value = value;
this.metricsValue = value.toLowerCase(java.util.Locale.ROOT);
}

public static Set<String> topicMessageTypeSet() {
Expand Down Expand Up @@ -67,6 +69,6 @@ public static TopicMessageType parseFromMessageProperty(Map<String, String> mess
}

public String getMetricsValue() {
return value.toLowerCase();
return metricsValue;
}
}
6 changes: 4 additions & 2 deletions remoting/src/main/java/org/apache/rocketmq/remoting/common/RemotingHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,10 +369,12 @@ public static CompletableFuture<Void> convertChannelFutureToCompletableFuture(Ch
}

public static String getRequestCodeDesc(int code) {
return REQUEST_CODE_MAP.getOrDefault(code, String.valueOf(code));
String desc = REQUEST_CODE_MAP.get(code);
return desc != null ? desc : String.valueOf(code);
}

public static String getResponseCodeDesc(int code) {
return RESPONSE_CODE_MAP.getOrDefault(code, String.valueOf(code));
String desc = RESPONSE_CODE_MAP.get(code);
return desc != null ? desc : String.valueOf(code);
}
}
Loading