[ISSUE #10676] Sanitize telemetry exception logs - #10677
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #10677 +/- ##
=============================================
- Coverage 48.31% 48.22% -0.10%
+ Complexity 13511 13480 -31
=============================================
Files 1380 1380
Lines 101091 101106 +15
Branches 13101 13103 +2
=============================================
- Hits 48844 48758 -86
- Misses 46285 46360 +75
- Partials 5962 5988 +26 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Review by github-manager-bot
Summary
Replaces full protobuf serialization in exception logs with a compact diagnostic summary, preventing sensitive data (e.g., thread stack traces) from leaking into log output.
Findings
- [Info] — The method correctly extracts diagnostic fields (command type, status code, nonce, client type) while omitting potentially sensitive payloads.
- [Info] — The on is well-structured. correctly includes only the nonce and omits the actual stack trace content.
- [Info] — Test explicitly verifies that the secret stack trace string does NOT appear in the summary. Good negative assertion.
Suggestions
- [Info] Consider adding a case test that verifies and appear in the summary, for completeness of the branch coverage. Minor — not blocking.
Automated review by github-manager-bot
Review by github-manager-botSummaryReplaces full protobuf Findings
Suggestions
Automated review by github-manager-bot |
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
Defensive fix with proper validation and test coverage. LGTM.
Automated review by github-manager-bot
|
Consolidated into #10717; both changes sanitize ClientActivity telemetry and Settings diagnostics. |
Summary
TelemetryCommandlogging inClientActivity.processTelemetryExceptionwith a compact request summary.Motivation
Closes #10676.
When client telemetry processing fails with an internal error, the previous warning log serialized the full protobuf request via
request:{}. Client telemetry may include verbose or sensitive runtime details such as thread stack traces, so logs should stay bounded and diagnostic-focused.Tests
mvn -pl proxy -Dtest=ClientActivityTest -DfailIfNoTests=false testResult: BUILD SUCCESS; 16 tests passed; checkstyle reported 0 violations. The run emits existing JaCoCo instrumentation warnings under the local JDK, but tests and build completed successfully.