Skip to content

[ISSUE #10806] Log proxy remoting cleanup failures #10807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aias00 wants to merge 2 commits into
base: develop
Choose a base branch
from
+28 −1
Open

[ISSUE #10806] Log proxy remoting cleanup failures #10807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70d707f
fix: log proxy remoting cleanup failures
Aias00 Aug 4, 2026
aed0ef5
test: remove remoting protocol conflict marker
Aias00 Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion proxy/src/main/java/org/apache/rocketmq/proxy/remoting/RemotingProtocolServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,11 +393,26 @@ protected void cleanExpiredRequestInQueue(ThreadPoolExecutor threadPoolExecutor,
} else {
break;
}
} catch (Throwable ignored) {
} catch (Throwable t) {
log.warn("clean expired remoting request failed. queueSize:{}, maxWaitTimeMillsInQueue:{}",
safeQueueSize(threadPoolExecutor), maxWaitTimeMillsInQueue, t);
break;
}
}
}

private int safeQueueSize(ThreadPoolExecutor threadPoolExecutor) {
try {
BlockingQueue<Runnable> queue = threadPoolExecutor == null ? null : threadPoolExecutor.getQueue();
if (queue == null) {
return -1;
}
return queue.size();
} catch (Throwable ignored) {
return -1;
}
}

private RequestTask castRunnable(final Runnable runnable) {
try {
if (runnable instanceof FutureTaskExt) {
Expand Down
12 changes: 12 additions & 0 deletions proxy/src/test/java/org/apache/rocketmq/proxy/remoting/RemotingProtocolServerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

package org.apache.rocketmq.proxy.remoting;

import java.util.concurrent.ThreadPoolExecutor;
import org.apache.rocketmq.remoting.RemotingServer;
import org.apache.rocketmq.remoting.protocol.RequestHeaderRegistry;
import org.junit.Test;
Expand Down Expand Up @@ -44,4 +45,15 @@ public void shouldInitializeRequestHeaderRegistryWhenRegisteringProcessors() {
verify(requestHeaderRegistry).initialize();
}
}

@Test(timeout = 1000)
public void testCleanExpiredRequestInQueueBreaksWhenQueueAccessFails() {
RemotingProtocolServer server = Mockito.mock(RemotingProtocolServer.class, Mockito.CALLS_REAL_METHODS);
ThreadPoolExecutor executor = Mockito.mock(ThreadPoolExecutor.class);
Mockito.when(executor.getQueue()).thenThrow(new RuntimeException("queue unavailable"));

server.cleanExpiredRequestInQueue(executor, 1);

Mockito.verify(executor, Mockito.atMost(2)).getQueue();
}
}
Loading