[ISSUE #10822] Classify BrokerShutdownTest as a medium Bazel test - #10821
Merged
fuyou001 merged 1 commit intoAug 6, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #10821 +/- ##
=============================================
- Coverage 48.32% 48.26% -0.07%
+ Complexity 13516 13503 -13
=============================================
Files 1380 1380
Lines 101138 101138
Branches 13120 13120
=============================================
- Hits 48876 48815 -61
- Misses 46298 46335 +37
- Partials 5964 5988 +24 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fuyou001
marked this pull request as ready for review
August 6, 2026 08:31
RockteMQ-AI
approved these changes
Aug 6, 2026
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
Fixes the flaky BrokerShutdownTest timeout by correctly classifying it as a medium Bazel test. The test runs four full broker lifecycle cycles which legitimately exceeds the small (60s) timeout — moving to medium (300s) is the right call.
LGTM. Clean, minimal change with clear justification.
Automated review by github-manager-bot
ShannonDing
approved these changes
Aug 6, 2026
RockteMQ-AI
approved these changes
Aug 11, 2026
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
Summary
Defensive fix with proper validation and test coverage. LGTM.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Brief Description
Classify
BrokerShutdownTestas a Bazelmediumtest so that its generated test rule receives a timeout appropriate for its workload.BrokerShutdownTestperforms four complete broker initialize, start, and shutdown cycles. Broker shutdown serially stops Netty event executors, message-store services, POP services, timer services, and other background resources. In the observed GitHub Actions failure, the target inherited the defaultsmallclassification and timed out after 61.6 seconds while the fourth shutdown was progressing normally.The same timeout was also observed on unrelated pull requests, so this is an existing test-size classification issue rather than a regression from the triggering change.
Observed failure: https://github.com/apache/rocketmq/actions/runs/31065433437/job/92502049511
This change only adjusts the Bazel timeout classification. Production code and test behavior are unchanged.
How Did You Test This Change?
git diff --checksuccessfully.GenTestRulesmaps entries inmedium_teststosize = "medium".broker/BUILD.bazelclassification change.