[ISSUE #10899] Fix missing message-out metrics for KV POP - #10900
[ISSUE #10899] Fix missing message-out metrics for KV POP#10900majialoong wants to merge 2 commits into
Conversation
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
Fix missing BrokerStats and OTel message-out metrics in KV POP consumption path. The recordPopMessageOut method is correctly placed in handleGetMessageResult and properly distinguishes between normal and retry topics using KeyBuilder.parseNormalTopic. System topic/group detection follows existing patterns.
Comprehensive test coverage including normal topic, V1/V2 retry topic, and edge cases (empty/not-found results). Tests verify that retry topics are correctly parsed to the underlying normal topic for the LABEL_TOPIC attribute.
LGTM — clean, well-tested fix that restores parity between KV POP and traditional POP metrics.
Automated review by github-manager-bot
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #10900 +/- ##
=============================================
- Coverage 48.46% 48.35% -0.12%
+ Complexity 13584 13554 -30
=============================================
Files 1380 1380
Lines 101195 101213 +18
Branches 13130 13133 +3
=============================================
- Hits 49040 48937 -103
- Misses 46188 46285 +97
- Partials 5967 5991 +24 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
Adds missing message-out metrics recording for KV POP consumption in PopConsumerService. The new recordPopMessageOut method correctly tracks message count, size, topic, consumer group, and retry status via both BrokerStatsManager and OpenTelemetry metrics.
Well-structured fix with proper test coverage. LGTM.
Automated review by github-manager-bot
|
Hi @lizhimins , please take a look at this PR when have time, thanks ! |
Which Issue(s) This PR Fixes
Brief Description
Fix missing BrokerStats and OTel message-out metrics in KV POP, restoring Consume TPS and aligning the statistics with traditional POP.
How Did You Test This Change?
Added unit tests and performed local KV POP verification. Confirmed the updated Consume TPS through
mqadmin consumerProgressand the related statistics instats.log.