Skip to content

[ISSUE #10894] Enforce Lite subscription quota for complete and batch updates #10919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
btlqql wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[ISSUE #10894] Enforce Lite subscription quota for complete and batch updates #10919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions broker/src/main/java/org/apache/rocketmq/broker/lite/LiteSubscriptionRegistryImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,9 @@ public void addPartialSubscription(String clientId, String group, String topic,
if (!liteLifecycleManager.isSubscriptionActive(topic, lmqName)) {
continue;
}
if (!isLiteTopicSubscribed(clientGroup, lmqName) && getActiveSubscriptionNum() >= maxCount) {
throw new LiteQuotaException("lite subscription quota exceeded " + maxCount);
}
thisSub.addLiteTopic(lmqName);
// First remove the old subscription
if (LiteMetadataUtil.isSubLiteExclusive(group, brokerController)) {
Expand Down Expand Up @@ -147,6 +150,10 @@ public void addCompleteSubscription(String clientId, String group, String topic,
removeTopicGroup(clientGroup, lmqName, false);
});
lmqNameNew.forEach(lmqName -> {
long maxCount = brokerController.getBrokerConfig().getMaxLiteSubscriptionCount();
if (!isLiteTopicSubscribed(clientGroup, lmqName) && getActiveSubscriptionNum() >= maxCount) {
throw new LiteQuotaException("lite subscription quota exceeded " + maxCount);
}
thisSub.addLiteTopic(lmqName);
addTopicGroup(clientGroup, lmqName);
});
Expand Down Expand Up @@ -269,6 +276,11 @@ public void cleanSubscription(String lmqName, boolean notifyClient) {
}
}

protected boolean isLiteTopicSubscribed(ClientGroup clientGroup, String lmqName) {
Set<ClientGroup> topicGroupSet = liteTopic2Group.get(lmqName);
return topicGroupSet != null && topicGroupSet.contains(clientGroup);
}

protected void addTopicGroup(ClientGroup clientGroup, String lmqName) {
Set<ClientGroup> topicGroupSet = liteTopic2Group
.computeIfAbsent(lmqName, k -> ConcurrentHashMap.newKeySet());
Expand Down