Skip to content

[ISSUE #9515] Return origin handle to consumer when changeInvisibleDuration encounters flow limit - #9516

Merged
lollipopjin merged 1 commit into
apache:developfrom
qianye1001:issue9515
Jul 8, 2025
Merged

[ISSUE #9515] Return origin handle to consumer when changeInvisibleDuration encounters flow limit#9516
lollipopjin merged 1 commit into
apache:developfrom
qianye1001:issue9515

Conversation

@qianye1001

Copy link
Copy Markdown
Contributor

Which Issue(s) This PR Fixes

Fixes #9515

Brief Description

How Did You Test This Change?

@codecov-commenter

codecov-commenter commented Jul 3, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.98%. Comparing base (c3c4101) to head (b4080a3).
⚠️ Report is 226 commits behind head on develop.

Files with missing lines Patch % Lines
...cketmq/proxy/grpc/v2/GrpcMessagingApplication.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9516      +/-   ##
=============================================
- Coverage      48.01%   47.98%   -0.03%     
+ Complexity     12024    12016       -8     
=============================================
  Files           1312     1312              
  Lines          92659    92663       +4     
  Branches       11849    11850       +1     
=============================================
- Hits           44486    44468      -18     
- Misses         42660    42678      +18     
- Partials        5513     5517       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lizhimins

Copy link
Copy Markdown
Member

客户端收到 changeInvisibleDurationResponse 时候无论 status 如何都应该采纳服务端返回的 handle,还是仅在 status 为 OK 时采纳

@lollipopjin lollipopjin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin
lollipopjin merged commit 3d94585 into apache:develop Jul 8, 2025
10 of 13 checks passed
hechen0 pushed a commit to hechen0/rocketmq that referenced this pull request Aug 18, 2025
…leDuration encounters flow limit

 Return origin handle to consumer when changeInvisibleDuration encounters flow limit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Return origin handle to consumer when changeInvisibleDuration encounters flow limit

4 participants