Skip to content

[ISSUE #9537] MQClientAPIFactory Implement NameServerUpdateCallback interface - #9538

Merged
lizhimins merged 4 commits into
apache:developfrom
qianye1001:clientApi
Jul 11, 2025
Merged

[ISSUE #9537] MQClientAPIFactory Implement NameServerUpdateCallback interface#9538
lizhimins merged 4 commits into
apache:developfrom
qianye1001:clientApi

Conversation

@qianye1001

Copy link
Copy Markdown
Contributor

Which Issue(s) This PR Fixes

Fixes #9537

Brief Description

How Did You Test This Change?

lollipopjin
lollipopjin previously approved these changes Jul 11, 2025

@lollipopjin lollipopjin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter

codecov-commenter commented Jul 11, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.92%. Comparing base (9337904) to head (2850df0).
⚠️ Report is 13 commits behind head on develop.

Files with missing lines Patch % Lines
...ketmq/client/impl/mqclient/MQClientAPIFactory.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9538      +/-   ##
=============================================
- Coverage      48.00%   47.92%   -0.09%     
+ Complexity     12026    12010      -16     
=============================================
  Files           1312     1312              
  Lines          92696    92699       +3     
  Branches       11856    11855       -1     
=============================================
- Hits           44496    44423      -73     
- Misses         42687    42759      +72     
- Partials        5513     5517       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lizhimins
lizhimins merged commit 76cee72 into apache:develop Jul 11, 2025
14 of 19 checks passed
hechen0 pushed a commit to hechen0/rocketmq that referenced this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] MQClientAPIFactory Implement NameServerUpdateCallback interface

4 participants