Skip to content

[ISSUE #9626] Prevent premature offset commit before consumer record flush - #9627

Merged
lollipopjin merged 2 commits into
apache:developfrom
lizhimins:fix-commit-offset
Aug 22, 2025
Merged

[ISSUE #9626] Prevent premature offset commit before consumer record flush#9627
lollipopjin merged 2 commits into
apache:developfrom
lizhimins:fix-commit-offset

Conversation

@lizhimins

Copy link
Copy Markdown
Member

Which Issue(s) This PR Fixes

Fixes #9626

Brief Description

How Did You Test This Change?

@codecov-commenter

codecov-commenter commented Aug 21, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.35294% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.98%. Comparing base (f40a69f) to head (e819344).
⚠️ Report is 202 commits behind head on develop.

Files with missing lines Patch % Lines
...g/apache/rocketmq/broker/pop/PopConsumerCache.java 82.35% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9627      +/-   ##
=============================================
- Coverage      48.15%   47.98%   -0.18%     
+ Complexity     12083    12040      -43     
=============================================
  Files           1313     1313              
  Lines          92839    92836       -3     
  Branches       11870    11868       -2     
=============================================
- Hits           44710    44548     -162     
- Misses         42636    42764     +128     
- Partials        5493     5524      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lollipopjin lollipopjin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin
lollipopjin merged commit e6a587a into apache:develop Aug 22, 2025
16 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Prevent premature offset commit before consumer record flush

4 participants