[ISSUE #9701] Synchronize metrics shutdown to prevent JVM crashes during broker shutdown - #9702
Merged
RongtongJin merged 2 commits intoSep 15, 2025
Conversation
guyinyou
force-pushed
the
dev_fix_broker_metrics_shutdown
branch
from
September 15, 2025 03:24
6584ed7 to
867f778
Compare
- Change async shutdown to sync blocking wait in BrokerMetricsManager - Ensure proper shutdown order to avoid race conditions - Prevent accessing dependencies after they are shutdown - Use join() with timeout to wait for CompletableFuture completion - Apply fix to all metrics exporter types (OTLP_GRPC, PROM, LOG)
guyinyou
force-pushed
the
dev_fix_broker_metrics_shutdown
branch
from
September 15, 2025 03:26
867f778 to
06d0d36
Compare
guyinyou
force-pushed
the
dev_fix_broker_metrics_shutdown
branch
from
September 15, 2025 04:23
66272d1 to
ea721a2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9702 +/- ##
=============================================
- Coverage 48.24% 48.10% -0.14%
+ Complexity 12150 12110 -40
=============================================
Files 1313 1313
Lines 93081 93093 +12
Branches 11890 11902 +12
=============================================
- Hits 44906 44785 -121
- Misses 42653 42765 +112
- Partials 5522 5543 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RongtongJin
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #9701
Brief Description
How Did You Test This Change?