[SPARK-56464][SS] Reset numRowsRemoved to 0 properly on the progress event for no batch triggers#55331
Open
HeartSaVioR wants to merge 8 commits intoapache:masterfrom
Open
[SPARK-56464][SS] Reset numRowsRemoved to 0 properly on the progress event for no batch triggers#55331HeartSaVioR wants to merge 8 commits intoapache:masterfrom
HeartSaVioR wants to merge 8 commits intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to reset
numRowsRemovedto 0 when numRowsRemoved > 0 for the last batch and there is no batch being triggered.numRowsUpdatedandnumRowsDroppedByWatermarkwere properly reset to 0 but we missed to handlenumRowsRemoved.Why are the changes needed?
The progress for no batch trigger could have
numRowsRemoved> 0 when numRowsRemoved > 0 for the last batch, which is confusing. Also some tests can be flaky due to this.Does this PR introduce any user-facing change?
No.
How was this patch tested?
New UT.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude 4.6 Opus