Skip to content

[SPARK-56471][BUILD][INFRA] Remove release-time binary deletion workaround and CI JAR/class checks#55337

Closed
sarutak wants to merge 1 commit intoapache:masterfrom
sarutak:revert-test-jars-workaround
Closed

[SPARK-56471][BUILD][INFRA] Remove release-time binary deletion workaround and CI JAR/class checks#55337
sarutak wants to merge 1 commit intoapache:masterfrom
sarutak:revert-test-jars-workaround

Conversation

@sarutak
Copy link
Copy Markdown
Member

@sarutak sarutak commented Apr 14, 2026

What changes were proposed in this pull request?

This PR is a part of SPARK-56352, reverting the workarounds introduced for SPARK-51318, which are no longer needed now that all pre-built test binaries have been removed from the repository by SPARK-56353, SPARK-56364 and SPARK-56407.

Changes:

  • Remove the binary deletion block from release-tag.sh that removed test JARs/classes and truncated dev/test-jars.txt/dev/test-classes.txt during the release process, along with the corresponding git revert that restored them after tagging.
  • Remove the JAR/class file rejection checks from dev/is-changed.py that prevented adding .jar and .class files in CI.
  • Delete dev/test-jars.txt and dev/test-classes.txt which are now empty and no longer referenced.

Reverts:

Why are the changes needed?

All pre-built test binaries have been removed and replaced with dynamic generation at test time. There are no longer any .jar or .class files in the source tree that need to be stripped during releases, so the workaround is fully unnecessary.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

GA.

Was this patch authored or co-authored using generative AI tooling?

Kiro CLI / Opus 4.6

…and is-changed.py JAR/class checks

Now that all pre-built test binaries have been removed (SPARK-56353,
SPARK-56364, SPARK-56407), the release-time workaround and CI checks
are no longer needed.

Reverts:
- e4eded8 [SPARK-51665] Truncate test-jars.txt/test-classes.txt during release
- 15eaa52 [SPARK-51618] Add a check to reject jars in CI
- 0528ac7 [SPARK-51623] Remove class files in source releases
Copy link
Copy Markdown
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sarutak .

So, SPARK-56352 (Remove pre-built test JAR and class files from the repository) is the umbrella JIRA issue this topic? And, this PR is the last piece?

cc @HyukjinKwon , @pan3793 , @LuciferYang , @yaooqinn

@pan3793
Copy link
Copy Markdown
Member

pan3793 commented Apr 14, 2026

which branch will be used for the release manager to trigger the release workflow? always master or on the release branch(e.g., branch-4.0)?

@dongjoon-hyun
Copy link
Copy Markdown
Member

And, FYI, @huaxingao as the release manager for Apache Spark 4.2.0 and @holdenk as the release manager of Apache Spark 3.5.9. You may be affected by this.

Copy link
Copy Markdown
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!!

@sarutak
Copy link
Copy Markdown
Member Author

sarutak commented Apr 15, 2026

To @dongjoon-hyun

So, SPARK-56352 (Remove pre-built test JAR and class files from the repository) is the umbrella JIRA issue this topic?

Yes. I've updated the description to mention that this PR is a part of SPARK-56352 like other subtasks.

And, this PR is the last piece?

I'm planning to add one more task to add a check to GA ensuring no more .class and .jar are added.

To @pan3793

which branch will be used for the release manager to trigger the release workflow? always master or on the release branch(e.g., branch-4.0)?

The workflow defined in release.yml in master is triggered periodically and the target branch is parameterized by branch (master by default).
https://github.com/apache/spark/blob/master/.github/workflows/release.yml#L83

Since the workflow checks out the target branch's source tree, release-tag.sh from that branch is used. So even without backporting this PR to release branches, this change doesn't affect them.

@sarutak sarutak closed this in d680761 Apr 15, 2026
@sarutak
Copy link
Copy Markdown
Member Author

sarutak commented Apr 15, 2026

Merged to master. Thank you all !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants