[SPARK-56471][BUILD][INFRA] Remove release-time binary deletion workaround and CI JAR/class checks#55337
[SPARK-56471][BUILD][INFRA] Remove release-time binary deletion workaround and CI JAR/class checks#55337sarutak wants to merge 1 commit intoapache:masterfrom
Conversation
…and is-changed.py JAR/class checks Now that all pre-built test binaries have been removed (SPARK-56353, SPARK-56364, SPARK-56407), the release-time workaround and CI checks are no longer needed. Reverts: - e4eded8 [SPARK-51665] Truncate test-jars.txt/test-classes.txt during release - 15eaa52 [SPARK-51618] Add a check to reject jars in CI - 0528ac7 [SPARK-51623] Remove class files in source releases
There was a problem hiding this comment.
Thank you, @sarutak .
So, SPARK-56352 (Remove pre-built test JAR and class files from the repository) is the umbrella JIRA issue this topic? And, this PR is the last piece?
cc @HyukjinKwon , @pan3793 , @LuciferYang , @yaooqinn
|
which branch will be used for the release manager to trigger the release workflow? always master or on the release branch(e.g., |
|
And, FYI, @huaxingao as the release manager for Apache Spark 4.2.0 and @holdenk as the release manager of Apache Spark 3.5.9. You may be affected by this. |
Yes. I've updated the description to mention that this PR is a part of SPARK-56352 like other subtasks.
I'm planning to add one more task to add a check to GA ensuring no more To @pan3793
The workflow defined in Since the workflow checks out the target branch's source tree, |
|
Merged to |
What changes were proposed in this pull request?
This PR is a part of SPARK-56352, reverting the workarounds introduced for SPARK-51318, which are no longer needed now that all pre-built test binaries have been removed from the repository by SPARK-56353, SPARK-56364 and SPARK-56407.
Changes:
release-tag.shthat removed test JARs/classes and truncateddev/test-jars.txt/dev/test-classes.txtduring the release process, along with the correspondinggit revertthat restored them after tagging.dev/is-changed.pythat prevented adding.jarand.classfiles in CI.dev/test-jars.txtanddev/test-classes.txtwhich are now empty and no longer referenced.Reverts:
Why are the changes needed?
All pre-built test binaries have been removed and replaced with dynamic generation at test time. There are no longer any
.jaror.classfiles in the source tree that need to be stripped during releases, so the workaround is fully unnecessary.Does this PR introduce any user-facing change?
No.
How was this patch tested?
GA.
Was this patch authored or co-authored using generative AI tooling?
Kiro CLI / Opus 4.6